Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new releases for CAPA cluster templates #1352

Merged
merged 8 commits into from
Jun 21, 2024
Merged

Conversation

nprokopic
Copy link
Contributor

What does this PR do?

Towards giantswarm/roadmap#3466

  • CAPA only change for new releases: render release version in config instead of cluster-aws version in App resource.

What is the effect of this change to users?

Users must specify --release flag when rendering templates for new CAPA clusters.

What does it look like?

See --release flag and .global.release.version config set, while App .spec.version is not set.

kubectl gs template cluster --provider capa --name nikola --organization giantswarm --release 25.0.0
---
apiVersion: v1
data:
  values: |
    global:
      connectivity:
        availabilityZoneUsageLimit: 3
        network: {}
        topology: {}
      controlPlane: {}
      metadata:
        name: nikola
        organization: giantswarm
        preventDeletion: false
      nodePools:
        nodepool0:
          instanceType: m5.xlarge
          maxSize: 10
          minSize: 3
          rootVolumeSizeGB: 8
      providerSpecific: {}
      release:
        version: 25.0.0
kind: ConfigMap
metadata:
  creationTimestamp: null
  labels:
    giantswarm.io/cluster: nikola
  name: nikola-userconfig
  namespace: org-giantswarm
---
apiVersion: application.giantswarm.io/v1alpha1
kind: App
metadata:
  labels:
    app-operator.giantswarm.io/version: 0.0.0
  name: nikola
  namespace: org-giantswarm
spec:
  catalog: cluster
  config:
    configMap:
      name: ""
      namespace: ""
    secret:
      name: ""
      namespace: ""
  kubeConfig:
    context:
      name: ""
    inCluster: true
    secret:
      name: ""
      namespace: ""
  name: cluster-aws
  namespace: org-giantswarm
  userConfig:
    configMap:
      name: nikola-userconfig
      namespace: org-giantswarm
  version: ""

Any background context you can provide?

What is needed from the reviewers?

Check if I missed to change something.

Do the docs need to be updated?

I don't think so.

Should this change be mentioned in the release notes?

  • CHANGELOG.md has been updated

Is this a breaking change?

Maybe, as --release flag is needed for CAPA clusters now, but's a change for CAPA clusters, and I don't think it's a change for kubectl-gs.

@nprokopic nprokopic requested a review from a team as a code owner June 20, 2024 18:01
@nprokopic nprokopic requested review from a team June 20, 2024 18:01
@nprokopic
Copy link
Contributor Author

Will fix the tests.

internal/key/key.go Outdated Show resolved Hide resolved
internal/key/provider.go Outdated Show resolved Hide resolved
@nprokopic nprokopic merged commit fa68563 into main Jun 21, 2024
3 checks passed
@nprokopic nprokopic deleted the support-new-capa-releases branch June 21, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants