Update module version to v3 #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nprokopic
added
the
breaking-change
njuettner
approved these changes
Jun 27, 2024
marians
reviewed
Jun 27, 2024
CHANGELOG.md
Outdated
| @@ -13,7 +13,8 @@ and this project's packages adheres to [Semantic Versioning](http://semver.org/s | |||
|
|
|||
| ### Changed | |||
|
|
|||
| - CAPA only change for new releases: render release version in config instead of cluster-aws version in App resource. | |||
| - **BREAKING** CAPA only change for new releases: render release version in config instead of cluster-aws version in App resource. | |||
There was a problem hiding this comment.
I have to admit I don't really understand the changelog entry. Can we explain this in more natural language? Also, which commands are affected?
There was a problem hiding this comment.
I have updated changelog so it's more clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR bumps go module version to v3, due to a breaking change that has been added here #1352.
What is the effect of this change to users?
See #1352.
What does it look like?
See #1352.
Any background context you can provide?
giantswarm/roadmap#3466
Do the docs need to be updated?
Will check.
Should this change be mentioned in the release notes?
Is this a breaking change?
(Breaking changes are, for example, removal of commnds/flags or substantial changes in the meaning of a flag. If yes, please add the
breaking-changelabel to the PR.)Yes.