This repository has been archived by the owner on Dec 11, 2023. It is now read-only.
Apply k8s 1.18.5 #1046
Merged
Apply k8s 1.18.5 #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfussell
commented
Oct 19, 2020
tfussell
commented
Oct 19, 2020
tfussell
commented
Oct 19, 2020
MarcelMue
reviewed
Oct 21, 2020
| Selector: labels.SelectorFromSet(map[string]string{ | ||
| key.PodWatcherLabel: project.Name(), |
There was a problem hiding this comment.
Yes this seems incorrect. It should still be project.Name IMO. This chantge here could have unintended consequences for updates where the version might not be the project version version (while upgrading the nodes).
stone-z
approved these changes
Oct 22, 2020
MarcelMue
approved these changes
Oct 26, 2020
1 task
tfussell
commented
Oct 27, 2020
tfussell
commented
Oct 27, 2020
REVERT ME: use k8scloudconfig from dockerhub-qps-v7 branch go mod tidy add secret with token load secret as part of configuration add dockerhubToken to CI values base64 encode secret make secret kubernetes-compliant make secret safely quoted fix CI defaults fix secret mount pass DockerhubToken to controllers update test cases update test cases (goconst) fix configmap redefinition bump k8scloudconfig to v7.2.0 fmt
This reverts commit 26c478e.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/giantswarm/giantswarm/issues/12716
Kubernetes client-go v1.18 introduced a breaking change by adding context.Context to all API calls. This meant we had to release new major versions of all core libraries like operatorkit and apiextensions that also used client-go. This PR updates all of these libraries in kvm-operator so we can run on controls planes with k8s 1.18 and get updates to GS libraries. 80% of the code changes are simply updating the library major versions and adding context.Context to all API calls. The rest is compatibility fixes for the updated libraries such as the removal of certain features in operatorkit and reading certificates differently. I will highlight other questions and important changes with GitHub comments in the code.