This repository has been archived by the owner on Dec 11, 2023. It is now read-only.
Pass VM POD name & namespace to shutdown-deferrer (and update images) #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to find the right DrainerConfig for node drainage status, shutdown-deferrer needs to know the POD name and namespace it's running in. This is passed via Downward API as environment parameter.
tuommaki
changed the title
Because of node POD running with host network, bind to loopback address fails when using same port for all pods (when there's more than one tenant node on physical control plane machine). Use the same trick as for flannel health and calculate listen port from flannel VNI.
…/giantswarm/kvm-operator into pass-pod-info-to-shutdown-deferrer
|
Are e2e tests failing because of this change? How did manual testing go? Would be nice to have this info while reviewing. |
xh3b4sd
reviewed
Nov 5, 2018
service/controller/v15/resource/deployment/master_deployment.go
Outdated
Show resolved
Hide resolved
| r.logger.LogCtx(ctx, "level", "debug", "message", "keeping finalizers") | ||
| finalizerskeptcontext.SetKept(ctx) | ||
|
|
||
| return nil, nil |
kopiczko
reviewed
Nov 6, 2018
| Lifecycle: &apiv1.Lifecycle{ | ||
| PreStop: &apiv1.Handler{ | ||
| Exec: &apiv1.ExecAction{ | ||
| Command: []string{"/pre-shutdown-hook", fmt.Sprintf("%s/v1/defer/", key.ShutdownDeferrerListenAddress(customObject))}, |
There was a problem hiding this comment.
Now I see the whole picture. In a hindsight I think this whole shutdown-deferer repo could be put as another kvm-operator endpoint. We wouldn't have to maintain separate docker image.
There was a problem hiding this comment.
Original idea was to have reusable container that can be used for this purpose, but now that you say it, it is a bit dependent on the use case here so could make sense.
Co-Authored-By: tuommaki <1947505+tuommaki@users.noreply.github.com>
Co-Authored-By: tuommaki <1947505+tuommaki@users.noreply.github.com>
Co-Authored-By: tuommaki <1947505+tuommaki@users.noreply.github.com>
Co-Authored-By: tuommaki <1947505+tuommaki@users.noreply.github.com>
Co-Authored-By: tuommaki <1947505+tuommaki@users.noreply.github.com>
Co-Authored-By: tuommaki <1947505+tuommaki@users.noreply.github.com>
Co-Authored-By: tuommaki <1947505+tuommaki@users.noreply.github.com>
Co-Authored-By: tuommaki <1947505+tuommaki@users.noreply.github.com>
Co-Authored-By: tuommaki <1947505+tuommaki@users.noreply.github.com>
Co-Authored-By: tuommaki <1947505+tuommaki@users.noreply.github.com>
…/giantswarm/kvm-operator into pass-pod-info-to-shutdown-deferrer
|
Unsure about e2e but I'm pretty sure it's about environments. We agreed with @teemow that he'll test this manually in order to proceed with upcoming release. |
|
Oh, but approvals are not there. Waiting for them :) PTAL 😄 |
xh3b4sd
approved these changes
Nov 6, 2018
teemow
reviewed
Nov 6, 2018
| @@ -370,6 +377,18 @@ func ServiceAccountName(customObject v1alpha1.KVMConfig) string { | |||
| return ClusterID(customObject) | |||
| } | |||
|
|
|||
| func ShutdownDeferrerListenPort(customObject v1alpha1.KVMConfig) int { | |||
| return int(shutdownDeferrerPortBase + customObject.Spec.KVM.Network.Flannel.VNI) | |||
There was a problem hiding this comment.
Suggested change
| return int(shutdownDeferrerPortBase + customObject.Spec.KVM.Network.Flannel.VNI) | |
| // per tenant cluster we run one vm per host. the pod of the vm uses the host network. so this makes sure the port of the shutdown deferrer is unique per tenant vm. | |
| return int(shutdownDeferrerPortBase + customObject.Spec.KVM.Network.Flannel.VNI) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to find the right DrainerConfig for node drainage status,
shutdown-deferrer needs to know the POD name and namespace it's running
in. This is passed via Downward API as environment parameter.
Also prevent Endpoint to be deleted before corresponding node is shut down.