This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
Add rkt and docker support, new logging package #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @denderello #8 |
|
This issue #6 would be addressed here |
|
And also this issue #5 |
|
from the content side I'd give my LGTM |
|
lgtm |
hectorj2f
pushed a commit
that referenced
this pull request
Feb 25, 2016
Add rkt and docker support, new logging package
This was referenced Feb 25, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glogwhich wasn't working with the Cobra setup. We need to have a detailed logging output, thereby I decided to avoid other libraries such aslog.--use-rkt--use-dockerping @giantswarm/team-core