-
Notifications
You must be signed in to change notification settings - Fork 17
Conversation
c92f21a
to
ee5959f
Compare
var cacheOptions = cache.Options{ | ||
SyncPeriod: to.DurationP(c.resyncPeriod), | ||
} | ||
if c.namespace != "" { | ||
cacheOptions.DefaultNamespaces = map[string]cache.Config{ | ||
c.namespace: cache.Config{}, | ||
} | ||
} | ||
o := manager.Options{ | ||
// MetricsBindAddress is set to 0 in order to disable it. We do this | ||
// ourselves. | ||
MetricsBindAddress: DisableMetricsServing, | ||
Namespace: c.namespace, | ||
SyncPeriod: to.DurationP(c.resyncPeriod), | ||
Cache: cacheOptions, | ||
Metrics: server.Options{ | ||
// MetricsBindAddress is set to 0 in order to disable it. We do this | ||
// ourselves. | ||
BindAddress: DisableMetricsServing, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this for? It should be mentioned in CHANGELOG, and could also be moved to a different PR unless its fixing some issue introduced by dependency upgrade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it's only fixing issues with breaking changes in controller-runtime upgrade. Behavior is the same or at least should bé from what I read upstream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheoBrigitte I'll merge when you approve :)
edf9f61
to
2498e71
Compare
@@ -397,7 +408,6 @@ func (c *Controller) bootWithError(ctx context.Context) error { | |||
For(c.newRuntimeObjectFunc()). | |||
WithOptions(controller.Options{ | |||
MaxConcurrentReconciles: 1, | |||
Reconciler: c, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed because latest ctrl runtime packages added validation and the reconcilier is added later on
2498e71
to
6eba8b6
Compare
No description provided.