allow ownership job to fail #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,6 +39,6 @@ spec: | |||
| name=$(kubectl get chart --namespace=giantswarm -l app.kubernetes.io/name=prometheus-meta-operator --output=jsonpath="{.items[0].spec.name}") | |||
| namespace=$(kubectl get chart --namespace=giantswarm -l app.kubernetes.io/name=prometheus-meta-operator --output=jsonpath="{.items[0].spec.namespace}") | |||
| kubectl patch --type=merge --record=false -p '{"metadata":{"annotations":{"meta.helm.sh/release-name": "'"${name}"'","meta.helm.sh/release-namespace": "'"${namespace}"'"},"labels":{"app.kubernetes.io/managed-by": "Helm"}}}' -n "${namespace}" alertmanager alertmanager | |||
| kubectl patch --record=false -n "${namespace}" --type json --patch '[{ "op": "remove", "path": "/spec/alertmanagerConfigSelector/matchLabels/app.kubernetes.io~1managed-by", "value": "prometheus-meta-operator" }]' alertmanager alertmanager | |||
There was a problem hiding this comment.
Could you not check if the field exist instead?
There was a problem hiding this comment.
this will require either jq or yq
There was a problem hiding this comment.
do you think it's installed in giantswarm/docker-kubect ?
There was a problem hiding this comment.
I honestly have no idea but I think the script would be more proper because this basically ignores this step even if it fails for other reasons
There was a problem hiding this comment.
Could you not use grep though?
mcbenjemaa
force-pushed
the
ownership-job
branch
from
13afb23
to
41b32d4
Compare
mcbenjemaa
force-pushed
the
ownership-job
branch
from
41b32d4
to
8e22097
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The job also patch the Alertmanager resource to removes the label
managed-by: pmofrom
alertmanagerConfigSelector.If the field doesn't has the label, the job will fail. so deployment will be stuck