Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade nginx-ingress-controller to 0.21.0 #157

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

TheoBrigitte
Copy link
Member

@TheoBrigitte TheoBrigitte commented Nov 28, 2018

Required by: giantswarm/kubernetes-nginx-ingress-controller#70

Add nginx-ingress-controller version 0.21.0.

Copy link
Contributor

@indyfree indyfree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also remember to create the repo on aliyun, otherwise the build will fail IIRC

@TheoBrigitte
Copy link
Member Author

I though retagger would have taken care of that. So how do you do this ?

Copy link
Contributor

@MarcelMue MarcelMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change lgtm, not sure about aliyun.

@TheoBrigitte
Copy link
Member Author

nginx-ingress-controller repo on aliyun is already there

@TheoBrigitte TheoBrigitte merged commit 1bcd42d into master Nov 29, 2018
@TheoBrigitte TheoBrigitte deleted the nginx-ingress-controller-0.21.0 branch November 29, 2018 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants