capz support #49
Merged
capz support #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiunchinho
force-pushed
the
capz-support
branch
4 times, most recently
from
34bf609
to
cdee5dd
Compare
|
I kept some of the assertions we have on the ClusterCR, AzureClusterCR, MachinePoolCR and AzureMachinePoolCR tests. But I feel like we are mostly testing things that already covered by capz. |
fiunchinho
force-pushed
the
capz-support
branch
from
ac3ba8d
to
bd9308c
Compare
|
I can't approve as this was my PR originally. But LGTM |
fiunchinho
force-pushed
the
capz-support
branch
from
347b0a8
to
64eb449
Compare
fiunchinho
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.