Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new test for cilium health #67

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Add new test for cilium health #67

merged 2 commits into from
Sep 29, 2022

Conversation

whites11
Copy link
Contributor

Towards: https://github.com/giantswarm/giantswarm/issues/23554

this PR adds a new test that checks cilium app is deployed correctly and that cilium status returns an healthy result

@whites11 whites11 self-assigned this Sep 29, 2022
@whites11 whites11 requested a review from a team September 29, 2022 13:38
cilium_test.go Outdated
}

// Get Cluster.
var cluster *capiv1alpha3.Cluster
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var cluster *capiv1alpha3.Cluster
var cluster *capiv1alpha3.Cluster

This should be v1beta1 by now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is. Forgot to rename the import alias. fixed

@whites11 whites11 merged commit dc00b78 into legacy Sep 29, 2022
@whites11 whites11 deleted the cilium branch September 29, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants