Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

School Closed Error #30

Closed
mictsao opened this issue Jun 30, 2015 · 4 comments
Closed

School Closed Error #30

mictsao opened this issue Jun 30, 2015 · 4 comments

Comments

@mictsao
Copy link

mictsao commented Jun 30, 2015

After clicking the "Space Booking" checkbox under the timetable, the year fast forwards to a date in the future. This would repeat until it reaches January 1, 2024.

The schedule would also indicate that the school is closed. Even going back to the original date will results in a schedule that shows the school is closed.

Screenshots have been attached.
screen shot 2015-06-30 at 1 15 06 pm
screen shot 2015-06-30 at 1 15 15 pm

@rossdotparker
Copy link
Member

mictsao, thanks for posting this issue. The timetable only shows data from within the current school year, so scrolling into the future with always show this issue. To see the timetable in future years, please log out and log into another year (using the Options link on the login form). Hope this helps: if not, let me know. Ross

@mictsao
Copy link
Author

mictsao commented Jul 1, 2015

Hi Ross, thanks for getting back to me so quickly. The curious thing is that I didn't scroll to any dates. The system skips to a random future date when I check, "Space Booking", so the system involuntarily moves me to a future date. For example, after checking the "Space Booking" box, the date will now show 1 year into the future.

I have attached a screen recording help illustrate:
https://www.dropbox.com/s/om6sl0w7r05senj/School%20Closed%20Error.mov?dl=0

Your system is incredibly robust, and we've really enjoyed trying out the latest release. Great job!

Michael (michael.t@examguardian.com)

@rossdotparker
Copy link
Member

Michael, thanks for this. The video was vital in working out the issue, as it is US-date specific, and so we would never have found it as we use UK-style dates. It has now been fixed for v11, and the fix should be backwards compatible to v10. To patch your version, get /modules/Timetable/moduleFunctions.php from the commit linked below, and upload it to your install:

4768fc8

Let us know if this does the trick.

Thanks,

Ross

@mictsao
Copy link
Author

mictsao commented Jul 6, 2015

We successfully deployed the patch. This took care of the issue perfectly. Thank you Ross.
Michael

@mictsao mictsao closed this as completed Jul 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants