Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide stricter tests #39

Open
jwoLondon opened this issue Feb 9, 2018 · 2 comments
Open

Provide stricter tests #39

jwoLondon opened this issue Feb 9, 2018 · 2 comments

Comments

@jwoLondon
Copy link
Member

Currently 'tests' consist of working examples that are verified by visual inspection.

A useful addition would be tests that confirm that the json spec produced by a spec-generating function is what is expected. This would also allow documentation examples to be tested through elm-verify-examples.

We might also consider validating against Vega-Lite and Vega schemas, although there are still some cases where working VL/V examples can invalidate schemas.

@kachkaev
Copy link
Member

kachkaev commented Feb 9, 2018

Perhaps, using elm-test could be a solution – the package looks rather straightforward to get started with. I have some experience with setting up Travis CI for the github repos, so can help a bit here.

@kachkaev
Copy link
Member

kachkaev commented Feb 9, 2018

elm-css uses elm-test and might be a good source of inspiration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants