Fixes the disconnect command error #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This was removed in 8ecce9f as part of a cleanup, but this is needed to avoid an error on the disconnect command. ================== Traceback (most recent call last): File "/home/vlexar/main/vlexar/Giesela/musicbot/bot.py", line 626, in on_message response = await handler(**handler_kwargs) File "/home/vlexar/main/vlexar/Giesela/musicbot/commands/admin_commands.py", line 478, in cmd_disconnect await server.voice_client.disconnect() File "/usr/local/lib/python3.6/dist-packages/discord/voice_client.py", line 297, in disconnect File "/usr/local/lib/python3.6/dist-packages/websockets/protocol.py", line 396, in close def encode_data(self, data): File "/usr/local/lib/python3.6/dist-packages/discord/gateway.py", line 686, in close_connection TypeError: close_connection() got an unexpected keyword argument 'force' ================== * Specifically, the call to await server.voice_client.disconnect() doesn鈥檛 work without this back. 馃槃
shikhir-arora
added a commit
that referenced
this pull request
Dec 19, 2017
Fixes disconnect error /xref PR #40
shikhir-arora
added a commit
that referenced
this pull request
Dec 19, 2017
shikhir-arora
added a commit
that referenced
this pull request
Dec 19, 2017
Revert "Fixes disconnect error /xref PR #40"
siku2
pushed a commit
that referenced
this pull request
Aug 3, 2018
Fixes the disconnect command error
siku2
pushed a commit
that referenced
this pull request
Aug 3, 2018
Fixes disconnect error /xref PR #40
siku2
pushed a commit
that referenced
this pull request
Aug 3, 2018
siku2
pushed a commit
that referenced
this pull request
Aug 3, 2018
Revert "Fixes disconnect error /xref PR #40"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of a cleanup, but this is needed to avoid an error on the disconnect
command.
Specifically, the call to
await server.voice_client.disconnect()doesn鈥檛 work without this back. 馃槃
/cc @siku2