Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libuv osx-arm64 runtime support #1

Closed
deniszykov opened this issue Feb 21, 2023 · 10 comments
Closed

libuv osx-arm64 runtime support #1

deniszykov opened this issue Feb 21, 2023 · 10 comments

Comments

@deniszykov
Copy link

Hi! Thanks for your libuv-shared package!
I'm using it in my personal projects and and it only libuv up-to-date package on Nuget.
Wouldn't it be too hard to add osx-arm platform to build list?

@gigi81
Copy link
Owner

gigi81 commented Feb 21, 2023

Hi @deniszykov
That is a good point. I'm not sure to be honest how easy it would be. The build runs on azure DevOps as you can see. I don't think native arm64 osx images are available. Seems like they are not according to this microsoft/azure-pipelines-agent#3935

Also I'm not sure you can cross compile from an Intel based osx to arm64.

Anyway If you want to give it a go I would be happy to accept a PR for it. The build should run on the PR (except the publishing to nuget) so you can check yourself if successful. I understand if you will need to give it multiple tries :-)

@gigi81
Copy link
Owner

gigi81 commented Feb 21, 2023

BTW the repo you are looking for is here
https://luigigrilli.visualstudio.com/libuv/_git/libuv-build-nuget

@deniszykov
Copy link
Author

Thanks, I will try. Official docs says it is possible to build arm64 from Intel x86 mac.

@deniszykov
Copy link
Author

@gigi81 please enable forks in this repo.

@gigi81
Copy link
Owner

gigi81 commented Feb 23, 2023

That is already enabled. You should be able to fork as far as I can tell

@deniszykov
Copy link
Author

Still no luck :(
If you don't mind, invite me (deniszykov@gmail.com) into project and give contributor role, I will make separate branch and will setup universal build for macosx, then create PR. If it cost something to u I will cover it.

@gigi81
Copy link
Owner

gigi81 commented Feb 25, 2023

hi @deniszykov
I was not aware of all these limitations of ADO for public repos.
I move the whole thing here: https://github.com/gigi81/libuv-build-nuget
The build is still in ADO but at least you can fork and create a PR there.
would you mind closing this issue and re-creating one on the new repo? (Maybe link this one for reference)

@gigi81
Copy link
Owner

gigi81 commented Feb 25, 2023

okay I actually went ahead and added the build for osx-arm64 but I have no way to test it...
https://luigigrilli.visualstudio.com/libuv/_artifacts/feed/feed/NuGet/libuv-shared/overview/1.44.2.483

Do you want to give it a go and let me know if it works?

@deniszykov
Copy link
Author

deniszykov commented Feb 25, 2023

Hi @gigi81! Thanks for adding osx-arm64 support. This nuget feed is private. But I scrambled artifacts directly from pipeline, and they are working on MacOS with ARM.
I don't know how they are located in nuget package, I dropped them in runtimes/osx-x64/native/libuv.dylib and runtimes/osx-arm64/native/libuv.dylib directories on my machine.

@gigi81
Copy link
Owner

gigi81 commented Feb 25, 2023

Published version 1.44.2.485
Might take a few minutes to be visible in nuget.org.
Closing as solved

@gigi81 gigi81 closed this as completed Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants