Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go1.9.4 not currently supported... compile error - invalid flag in #cgo #24

Closed
wkhere opened this issue Feb 9, 2018 · 10 comments
Closed

Comments

@wkhere
Copy link

wkhere commented Feb 9, 2018

Hi!

Having problems compiling 0.9.6 (same for current master):

go build github.com/gijit/gi/vendor/github.com/glycerine/golua/lua: invalid flag in #cgo LDFLAGS: /home/wk/go/src/github.com/gijit/gi/vendor/github.com/glycerine/golua/lua/../../../LuaJIT/LuaJIT/src/libluajit.a
Makefile:33: recipe for target 'build' failed

go version: 1.9.4

Any other prerequisites needed for compilation?

@glycerine
Copy link
Contributor

glycerine commented Feb 9, 2018 via email

@glycerine
Copy link
Contributor

glycerine commented Feb 9, 2018 via email

@wkhere
Copy link
Author

wkhere commented Feb 9, 2018

OK thanks for the information.

@glycerine
Copy link
Contributor

@glycerine glycerine changed the title compile error - invalid flag in #cgo go1.9.4 not currently supported... compile error - invalid flag in #cgo Feb 9, 2018
@glycerine
Copy link
Contributor

I just pushed v0.9.7 which builds for me under go1.9.4. Give it a try and let me know how it goes.

@glycerine
Copy link
Contributor

Arg. Sorry. That's going to be broken. Still working on this.

@wkhere
Copy link
Author

wkhere commented Feb 9, 2018

I understand. Thank you for the fast responses.

No hurry for me - OTOH the change rsc introduced in Go 1.9.4 also went to 1.10 which will be released soon and will become $default go version for many, so I guess I'd be beneficial to have a fix or get around the problem.

@glycerine
Copy link
Contributor

they are holding up go1.10 to fix this. They won't release it until https://go-review.googlesource.com/c/go/+/92855/1/src/cmd/go/internal/work/security.go is included, which is what we need.

@glycerine
Copy link
Contributor

glycerine commented Feb 9, 2018

Ok. I found a workaround that seems to satisfy go1.94, at least on OSX. Try the most recent.

@glycerine
Copy link
Contributor

Fixed in v0.9.12. Note the new install instructions.

$ go get -d github.com/gijit/gi/cmd/gi                                                          
$ cd $GOPATH/src/github.com/gijit/gi && make install  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants