Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example/boolean.py and example/read_multi.py broken #271

Closed
gijzelaerr opened this issue Apr 22, 2021 · 2 comments
Closed

example/boolean.py and example/read_multi.py broken #271

gijzelaerr opened this issue Apr 22, 2021 · 2 comments
Milestone

Comments

@gijzelaerr
Copy link
Owner

they don't match the snap7 anymore. Maybe we should add checking these files to github actions also.

@gijzelaerr gijzelaerr added this to the 2.0 milestone Apr 22, 2021
@swamper123
Copy link
Contributor

We may should add/fix the examples in general. The code hasn't to be long, most stuff would be copy/paste, perhaps even stuff from the tests.
I would prefere multiple examples with less lines than one or few giant examples.

ToDos I think about could be:

  • Client. read (add typical Datatype here)
  • Client read as (add typical Datatype here)
  • Client. write (add typical Datatype here)
  • Client write async (add typical Datatype here)
  • Client do sth. more complex...like db_fill or db_get or handle with stuff like eb or ct. (maybe even this splitted in multiple files)
  • Logo-Client (which could be used 1:1 again perhaps?)
  • Server stuff? Or just an example server to play with the examples?
  • Partner stuff? (well..this may be a step for >2.0, since I don't know if any one of the typical suspects here has one/have ever dealed with such a thing .... also the main focus should be the Client anyway)

Just some suggestions from my side here.

@gijzelaerr gijzelaerr modified the milestones: 2.0, 1.2 Jul 7, 2021
@gijzelaerr gijzelaerr modified the milestones: 1.2, 1.3 Oct 20, 2021
@gijzelaerr gijzelaerr modified the milestones: 1.3, 1.4 Jan 17, 2023
@gijzelaerr gijzelaerr modified the milestones: 1.4, 1.5 Oct 24, 2023
@gijzelaerr gijzelaerr modified the milestones: 1.4, 1.5 May 2, 2024
@gijzelaerr
Copy link
Owner Author

i fixed the examples as much as possible in #524. @swamper123 do you still plan to add these examples? otherwise we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants