Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is.nan breaks in legacy browsers #4

Closed
tomchentw opened this issue Feb 26, 2020 · 1 comment
Closed

is.nan breaks in legacy browsers #4

tomchentw opened this issue Feb 26, 2020 · 1 comment

Comments

@tomchentw
Copy link

Hi, came from react-joyride and it throws on IE11, which traced back to is.nan:

https://github.com/gilbarbara/is-lite/blob/v0.6.0/src/index.ts#L163-L165

Number don't have the isNaN function defined in legacy browsers.

Question

Are you willing to support legacy browsers? Guess that might against your intention of having this package.
@gilbarbara
Copy link
Owner

hey

You can load a polyfill if you need to support legacy browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gilbarbara @tomchentw