Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement REPL with Python stdlib code and codeop #25

Closed
brandonwillard opened this issue Jun 30, 2019 · 9 comments
Closed

Implement REPL with Python stdlib code and codeop #25

brandonwillard opened this issue Jun 30, 2019 · 9 comments
Labels
help wanted Extra attention is needed

Comments

@brandonwillard
Copy link
Contributor

What do you think about using code and codeop to implement the basic REPL mechanics?

@gilch
Copy link
Owner

gilch commented Jun 30, 2019

That might be cleaner. I'm not sure how to do it though. The doctests are also closely tied to the REPL. I'm wondering how much they can or should hook into it.

@brandonwillard
Copy link
Contributor Author

I'll look into it quickly.

@gilch
Copy link
Owner

gilch commented Jun 30, 2019

The REPL could maybe use a startup banner too.

@gilch
Copy link
Owner

gilch commented Jul 1, 2019

The sybil/doctest setup is in conftest.py, btw.

@gilch gilch added the help wanted Extra attention is needed label Aug 4, 2019
@brandonwillard
Copy link
Contributor Author

brandonwillard commented Aug 5, 2019

Should we turn this into "Make a Jupyter kernel for Hissp" instead?

Some links:

@gilch
Copy link
Owner

gilch commented Aug 6, 2019

No we shouldn't. It is a goal of Hissp proper to have no dependencies. (This restriction does not apply to its tests, which need not be distributed in the hissp package.) The basic included REPL should use only the standard library.

We can certainly have a Lissp REPL based on IPython, but it must live in a separate repository, or at least be released as a separate package on PyPI. It will have independent releases and version numbers from Hissp itself. Which means we still need a basic one to include with Hissp.

Hebigo, on the other hand, does not share this goal. I'm fine with that only having an IPython REPL to start as well as reasonable dependencies.

@brandonwillard
Copy link
Contributor Author

Ah, yeah, then change it to ”Start a Project for a Hissp Jupyter Kernel".

@gilch
Copy link
Owner

gilch commented Aug 6, 2019

Rather than change this issue to the Kernel, we can add that as a separate issue. The original point of using the stdlib code/codeop may still be a good idea for the included basic REPL.

@gilch
Copy link
Owner

gilch commented Dec 5, 2020

I think the InteractiveConsole-based REPL from #62 is pretty good now.

@gilch gilch closed this as completed Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants