New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the docs for the argument order of FilePath.is_subdir #48

Merged

gildor478 merged 1 commit into gildor478:master from dmbaturin:soupault-35-doc-issue

Oct 28, 2022

Contributor

dmbaturin commented Jun 10, 2021

It looks like the behaviour of FilePath.is_subdir is the opposite of what the docs say.

utop # #require "fileutils";;

utop # FilePath.is_subdir "foo" "foo/bar" ;;
- : bool = false

utop # FilePath.is_subdir "foo/bar" "foo" ;;
- : bool = true

That causes me quite a bit of confusion during late night debugging (PataphysicalSociety/soupault#35).


          Fix the docs for the argument order of FilePath.is_subdir

79dae9f

Contributor Author

dmbaturin commented Nov 27, 2021

@gildor478 The issue still exists in the docs, please consider merging this PR.

gildor478 merged commit 575aac7 into gildor478:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet