Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing hash value from demangled Rust symbol names #108

Closed
jasonrhansen opened this issue Feb 1, 2019 · 3 comments
Closed

Remove trailing hash value from demangled Rust symbol names #108

jasonrhansen opened this issue Feb 1, 2019 · 3 comments

Comments

@jasonrhansen
Copy link

When demangling Rust symbol names, binutils addr2line removes the trailing hash value. The rustc_demangle crate allows Demangle to be formatted with or without the hash. I think this crate should match the behavior of binutils.

From rustc-demangle:

// With hash
assert_eq!(format!("{}", demangle("_ZN3foo17h05af221e174051e9E")), "foo::h05af221e174051e9");
// Without hash
assert_eq!(format!("{:#}", demangle("_ZN3foo17h05af221e174051e9E")), "foo");
@jonhoo
Copy link
Contributor

jonhoo commented Feb 4, 2019

@main-- awesome! Can we get a minor release with that change too pretty please? :p

@main--
Copy link
Contributor

main-- commented Feb 5, 2019

cc @fitzgen @philipc

@philipc
Copy link
Contributor

philipc commented Feb 7, 2019

Published 0.8.0. Had to be a major release because object is part of the public API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants