Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of Endianity once ByteOrder lands trait bounds #155

Closed
fitzgen opened this issue Nov 6, 2016 · 3 comments
Closed

Get rid of Endianity once ByteOrder lands trait bounds #155

fitzgen opened this issue Nov 6, 2016 · 3 comments
Labels
easy help wanted

Comments

@fitzgen
Copy link
Member

fitzgen commented Nov 6, 2016

Once BurntSushi/byteorder#60 lands, we won't need the Endianity wrapper around the ByteOrder trait.
@philipc
Copy link
Collaborator

philipc commented Nov 6, 2016

Probably should come up with a design for implementing #84 before doing any major changes here. eg we may need a wrapper anyway so that we can use struct {} instead of enum {}, to allow storing the endianity value at runtime, while still allowing fixed endianity to be compiled out.

@fitzgen
Copy link
Member Author

fitzgen commented Dec 30, 2016

FYI BurntSushi/byteorder#60 was merged.

@fitzgen fitzgen mentioned this issue Dec 30, 2016
Closed
@fitzgen
Copy link
Member Author

fitzgen commented Dec 30, 2016

As discussed in #84, we will need to keep Endianity.

@fitzgen fitzgen closed this as completed Dec 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fitzgen @philipc