Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log conditionally when not a zap.Logger #75

Closed
wants to merge 1 commit into from

Conversation

reesmanp
Copy link

Looking to resolve #74 by being smart about which function to call on the interface instead of just defaulting to Error().

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 45.34%. Comparing base (7d7b817) to head (e6ea949).
Report is 11 commits behind head on master.

Files Patch % Lines
zap.go 0.00% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   40.00%   45.34%   +5.34%     
==========================================
  Files           1        1              
  Lines          90       86       -4     
==========================================
+ Hits           36       39       +3     
+ Misses         51       44       -7     
  Partials        3        3              
Flag Coverage Δ
go- 45.34% <0.00%> (?)
go-1.19 45.34% <0.00%> (+5.34%) ⬆️
go-1.20 45.34% <0.00%> (?)
go-1.21 45.34% <0.00%> (?)
go-1.22 45.34% <0.00%> (?)
macos-latest 45.34% <0.00%> (?)
ubuntu-latest 45.34% <0.00%> (+5.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@appleboy appleboy closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use wrapped logger as the logger
3 participants