Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log conditionally when not a zap.Logger #75

Closed
wants to merge 1 commit into from
Closed

log conditionally when not a zap.Logger #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion zap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,10 @@
}
} else {
zl, ok := logger.(*zap.Logger)
if ok {

Check failure on line 117 in zap.go

View workflow job for this annotation

GitHub Actions / lint 

ifElseChain: rewrite if-else to switch statement (gocritic)
zl.Log(conf.DefaultLevel, "", fields...)
} else if conf.DefaultLevel == zapcore.InfoLevel {
logger.Info(path, fields...)
} else {
logger.Error(path, fields...)
}
Expand Down Expand Up @@ -165,7 +167,7 @@
zap.String("request", string(httpRequest)),
)
// If the connection is dead, we can't write a status to it.
c.Error(err.(error)) //nolint: errcheck
c.Error(err.(error)) // nolint: errcheck

Check failure on line 170 in zap.go

View workflow job for this annotation

GitHub Actions / lint 

directive `// nolint: errcheck` should be written without leading space as `//nolint: errcheck` (nolintlint)
c.Abort()
return
}
Expand Down
Loading