fatal error: concurrent map writes #3387
Comments
|
the main code of the timeout middleware |
|
tw.mu can't be locked http.ResponseWriter.Header() map. it can only lock you custom Writer struct. |
|
when timeout, the header should be custom, or reference https://github.com/gin-contrib/timeout you can reference net/http/server.go line:3316 (go ver:1.17.7) implementation. func (h *timeoutHandler) ServeHTTP(w ResponseWriter, r *Request) {
ctx := h.testContext
if ctx == nil {
var cancelCtx context.CancelFunc
ctx, cancelCtx = context.WithTimeout(r.Context(), h.dt)
defer cancelCtx()
}
r = r.WithContext(ctx)
done := make(chan struct{})
tw := &timeoutWriter{
w: w,
h: make(Header),
req: r,
}
panicChan := make(chan interface{}, 1)
go func() {
defer func() {
if p := recover(); p != nil {
panicChan <- p
}
}()
h.handler.ServeHTTP(tw, r)
close(done)
}()
select {
case p := <-panicChan:
panic(p)
case <-done:
tw.mu.Lock()
defer tw.mu.Unlock()
dst := w.Header()
for k, vv := range tw.h {
dst[k] = vv
}
if !tw.wroteHeader {
tw.code = StatusOK
}
w.WriteHeader(tw.code)
w.Write(tw.wbuf.Bytes())
case <-ctx.Done():
tw.mu.Lock()
defer tw.mu.Unlock()
w.WriteHeader(StatusServiceUnavailable)
io.WriteString(w, h.errorBody())
tw.timedOut = true
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Very randomly, I got my Gin application fatal error
How to reproduce
Expectations
Actual result
Environment
The text was updated successfully, but these errors were encountered: