-
Notifications
You must be signed in to change notification settings - Fork 239
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: only #include "ESP32/ESPNOWHelper.h" if PJON_INCLUDE_EN is defined #256
Comments
Ciao @xlfe is there any motivation why you did not include the helper in the ARDUINO interface dir (as the tcp or udp helpers of fred) considering that the helper depends on a custom arduino core? |
No that makes sense too actually. I guess the only reason not to is that it doesn't run on generic Arduino - but if you want to move it there I have no objections |
Another thing @xlfe why you include twice the helper both in |
@xlfe about custom core, the "norm" we have developed is just to fit in ARDUINO interface all arduino compatible cores see: https://github.com/gioblu/PJON/blob/master/src/interfaces/ARDUINO/PJON_ARDUINO_Interface.h#L30 |
Sounds sensible - no objections from me at all |
Consider that when compiling an ESPNOW sketch on ESP32, the interface used is ARDUINO, from where PJON takes all the system calls in the first place. |
true |
Thank you @xlfe for your clarifications, I will make the necessary changes. |
@xlfe it is a pleasure no probs, I am still reviewing your contribution, one thing I have noticed is that you include here: https://github.com/gioblu/PJON/blob/master/src/interfaces/ARDUINO/ESPNOWHelper.h#L3 |
Yes - removing the include from ESPNOW.h doesn't cause any problems |
Good @xlfe thank you again for testing it, I will remove those :) |
Otherwise I'm getting a compilation error for PJON :(
PJON_Interfaces.h :-
The text was updated successfully, but these errors were encountered: