Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tagged source code from repo; fix invalid platform IDs #53

Merged
merged 1 commit into from
Apr 13, 2016

Conversation

ivankravets
Copy link
Contributor

@ivankravets
Copy link
Contributor Author

@gioblu I see that your library is popular in PlatformIO Registry and users report that we don't update it.

  1. Please don't remove version field from the manifest. We are working on PlatformIO 3.0 and powerful Library Manager. The semantic version is important for the valid dependencies.
  2. We would be grateful if you update version field with the valid repo tag as you do it for library.properties. Here is detailed explanation how PlatformIO Crawler handles version field.
  3. Currently, we have an issue with platform field and only PlatformIO platform IDs are supported.

Please sorry for inconveniences, we are working on improvements for the whole PlatformIO ecosystem.

@gioblu
Copy link
Owner

gioblu commented Apr 13, 2016

Ciao @ivankravets, I am sorry to have temporarily created some issues to the PlatformIO users. Thank you so much for your fix. I am now taking a closer look thanks to your links. I think PlatformIO platform is really amazing piece of work in terms of Systems Engineering and Integration, compliments again.

@gioblu gioblu merged commit c61ba27 into gioblu:master Apr 13, 2016
@ivankravets
Copy link
Contributor Author

@gioblu Thanks a lot for the warm words! The library has been updated http://platformio.org/lib/show/245/PJON

@gioblu gioblu added the bug label Jul 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants