Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe doesn't paint bottom non-border line in the JFrame? #40

Closed
GoogleCodeExporter opened this issue Apr 20, 2016 · 17 comments
Closed

Comments

@GoogleCodeExporter
Copy link

Various panels have different background colors when no explicit one is
set. It seems to be dependent on where they are and possibly what is on
them. See the attached screenshots depicting my system L&F on Windows XP
versus SeaGlass.

In the system L&F, the default background color for all panels seems to be
a gray, in SeaGlass it varies from a blue, to light gray, to white. I don't
think it's a big issue that different panels have different default
background colors depending on the component or such, but it's a problem
relative to other components. The JSplitPane divider area has a gray
background, but it doesn't match up with the white next to it. Also, it
seems a bit odd for a default panel to have white as a background color.

I should note that the app pictured there is incomplete, so the tabs
displayed have no panels in them or an empty JPanel per tab, and that the
panel containing the JTree has an explicit white background (if that helps).

Other than that, this is a nice looking L&F, thank you the good work :)

Original issue reported on code.google.com by mcbain....@gmail.com on 21 Mar 2010 at 5:43

Attachments:

@GoogleCodeExporter
Copy link
Author

Panels are transparent and show the shaded background through.

We will be changing the default background color to our typical #f8f8f8 gray in 
the next release, with a client 
property on the root pane to change it to the shaded look.

The shaded look is intended to integrate any toolbars with the title bar and 
general window frame. If you want 
to use it you would set a background color on a panel that is embedded in your 
content pane and the toolbars 
would look distinct.

The trees and such are supposed to be white. I'm not sure what class your "View 
by" and such are contained 
in. If you actually set the panel to be opaque using setOpaque(true) you should 
get a gray (f8) background. If 
you set a background color you'll get that.

Original comment by kahuxtable on 21 Mar 2010 at 11:33

@GoogleCodeExporter
Copy link
Author

[deleted comment]

1 similar comment
@GoogleCodeExporter
Copy link
Author

[deleted comment]

@GoogleCodeExporter
Copy link
Author

They're JPanels. I didn't set them explicitly opaque, or set the background
colors (other than for the JTree, which I set to white). I'm okay with the 
shaded
look, but the white was a bit odd considering it didn't match the blue on the 
right
either.

Original comment by mcbain....@gmail.com on 21 Mar 2010 at 11:43

@GoogleCodeExporter
Copy link
Author

Hmmm.... That's strange. Is this Sea Glass version 0.1.7.2? Or trunk? Or what?

Original comment by kahuxtable on 21 Mar 2010 at 11:48

@GoogleCodeExporter
Copy link
Author

I had originally done it against a 0.1.6. However to be sure, I just checked out
trunk and ran it against that. They still appear white.

Original comment by mcbain....@gmail.com on 21 Mar 2010 at 12:12

@GoogleCodeExporter
Copy link
Author

Okay, let me write something similar and verify. Thanks!

Original comment by kahuxtable on 21 Mar 2010 at 12:21

@GoogleCodeExporter
Copy link
Author

Well, I tried to write a test-case for you, but the test-case worked. So, the 
problem
must be a fault in my code then. So upon checking it out, I wasn't setting the
background color on the JTree, but on the container panel. The panels at the 
north
and south were being transparent and letting that white shine through. I didn't
notice before because the system L&F painted the north/south panel backgrounds.

However while checking this out, I did notice a single line at the bottom of the
JFrame just inside the border that wasn't being painted (it let the underlying 
window
shine through). Not sure what the cause of this is.

Sorry about the misfiled bug. :-/

Original comment by mcbain....@gmail.com on 21 Mar 2010 at 12:56

@GoogleCodeExporter
Copy link
Author

No problem.

Can you send a screen shot of the new issue with the single line not being 
painted?

Original comment by kahuxtable on 21 Mar 2010 at 1:00

@GoogleCodeExporter
Copy link
Author

Attached. I moved the window down on top of my taskbar, as it's a dark green of
sorts, and would provide a good contrast. It also happened in my previous 
test-case I
wrote, so it's not specific to my Eleven app. I hope this helps.

Original comment by mcbain....@gmail.com on 21 Mar 2010 at 1:05

Attachments:

@GoogleCodeExporter
Copy link
Author

Hmmm... That is peculiar. I'm possibly miscalculating something. Or not.

We'll eventually have some usage guidelines, but I'm busy working on some Maven 
plugins at the moment.

Original comment by kahuxtable on 21 Mar 2010 at 1:09

@GoogleCodeExporter
Copy link
Author

Original comment by kahuxtable on 21 Mar 2010 at 1:10

  • Changed title: Maybe doesn't paint bottom non-border line in the JFrame?

@GoogleCodeExporter
Copy link
Author

Set owner to kahuxtable.

Original comment by kahuxtable on 5 Jul 2010 at 1:44

@GoogleCodeExporter
Copy link
Author

I'm letting issue 39 marinate for awhile and looking at other issues, such as 
this one.

The outstanding problem is the bottom line issue, correct?

(Maybe I should make the background on JSplitPane be transparent, is that also 
the case?)

Original comment by kahuxtable on 13 Jul 2010 at 7:27

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

Yes, the non-painted bottom line is still the issue. The background of the 
JSplitPane is not transparent, and setting it to such doesn't change anything.

Original comment by mcbain....@gmail.com on 13 Jul 2010 at 8:44

@GoogleCodeExporter
Copy link
Author

Hi,
The problem with the last line not beeing painted is already fixed in the 
integration_rossi branch. 

Have fun,
- Rossi

Original comment by rosstaus...@googlemail.com on 15 Feb 2011 at 7:00

@GoogleCodeExporter
Copy link
Author

This issue is fixed in sealglass 0.2 that we just have released.
Please give this new version a try.

Have fun,
- Rossi

Original comment by rosstaus...@googlemail.com on 25 Jun 2012 at 8:42

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant