Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible memory leak? #17

Closed
travis-leith opened this issue Sep 21, 2021 · 2 comments
Closed

Possible memory leak? #17

travis-leith opened this issue Sep 21, 2021 · 2 comments

Comments

@travis-leith
Copy link
Contributor

Just looking at the documentation here: https://duckdb.org/docs/api/c/types
I noticed the following

Note that duckdb_value_varchar and duckdb_value_blob require the result to be de-allocated using duckdb_free.

Is this something we have to worry about in .net? I see for instance the following line of code in the data reader

        public override string GetString(int ordinal)
        {
            return PlatformIndependentBindings.NativeMethods.DuckDBValueVarchar(_queryResult, ordinal, _currentRow);
        }
@Giorgi
Copy link
Owner

Giorgi commented Sep 21, 2021

@Giorgi
Copy link
Owner

Giorgi commented Sep 24, 2021

Fixed by f2be8cb

@Giorgi Giorgi closed this as completed Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants