-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flush logs before status is complete #63
Comments
This line in |
Right, but the status is changed BEFORE the logs are flushed. Specifically, if you are listening for girder events where the log is updated, you can get a job whose status is completed but logs aren't flushed. This was surprising, as in a test I expected an error message to be in the logs when the error status was set (but it wasn't there yet). |
I would recommend adding |
I'm fine with that change. |
Added in PR #65. |
Currently, the job status can change to a completed state (error, success, or cancelled) without the logs being fully flushed.
The text was updated successfully, but these errors were encountered: