Add kwargs to public methods #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nurikk actually this doesn't do anything as far as I can see.. you don't use the that's not really consistent with how the library works for other providers (ie the PRs you linked), so I'd ask to please implement using the |
|
True, they are not being used in the request itself. @nurikk I'm assuming these are some custom set parameters that are being used to keep a mapping of the request and response itself? Or what was your intention here? |
|
Reverted the changes for now. |
|
Created a new PR #59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add kwargs to public methods. so we wouldn't get errors when using object spreading
ex:
TypeError: matrix() got an unexpected keyword argument 'extra_param1'#55
#49