Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember map extent #50 [Added functionality] #120

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Remember map extent #50 [Added functionality] #120

merged 3 commits into from
Mar 14, 2023

Conversation

harsh5902
Copy link
Contributor

Closes #50

πŸ› οΈ Fixes Issue

used localstorage of the user to remember the mapextent

πŸ‘¨β€πŸ’» Changes proposed

If user moves his/her pointer on the map and moves to new location then localstorage will store his session and next time when he/she starts the app will get the same location where they left before.

You can see the center latitude and longitude on the developer tools application tab

πŸ“· Screenshots

image

Remember map extent #50

used localstorage to remember the mapextent
Copy link
Owner

@nilsnolde nilsnolde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'd consolidate it to a coordinate and not split up lat & lon when storing it in localstorage. Also we should capture the zoom as well as the center coordinate.

Can we name the localstorage items last_center & last_zoom?

@harsh5902
Copy link
Contributor Author

Sure I will make the necessary changes as needed

@harsh5902
Copy link
Contributor Author

@nilsnolde I have made the necessary changes you pointed out and also used localstorage for zoom level as well

image

@nilsnolde
Copy link
Owner

LGTM, thanks!

@nilsnolde nilsnolde merged commit 2be5e14 into nilsnolde:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remember map extent
2 participants