Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade java 17 and dependencies #726

Merged
merged 2 commits into from
Jan 6, 2022
Merged

Upgrade java 17 and dependencies #726

merged 2 commits into from
Jan 6, 2022

Conversation

alainbodiguel
Copy link
Contributor

@alainbodiguel alainbodiguel commented Sep 20, 2021 •
edited

Fix #707
Fix #392

@alainbodiguel alainbodiguel self-assigned this Sep 20, 2021
@alainbodiguel alainbodiguel force-pushed the feature/java17nomdules branch 5 times, most recently from 28fe93d to 33ecf2f Compare September 24, 2021 12:03
@alainbodiguel alainbodiguel force-pushed the feature/java17nomdules branch 3 times, most recently from 4d3b2a9 to cc1d443 Compare October 7, 2021 13:08
@alainbodiguel alainbodiguel changed the title WIP: upgrade java 17 and dependencies Upgrade java 17 and dependencies Nov 9, 2021
sfalquier
sfalquier suggested changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@sfalquier sfalquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed a long time ago but forgotten to click on "Submit review" 😞
LGTM except a weird command in release.sh that needs explanations if relevant.

release.sh Outdated Show resolved Hide resolved
@alainbodiguel alainbodiguel merged commit 450cd70 into develop Jan 6, 2022
@alainbodiguel alainbodiguel deleted the feature/java17nomdules branch January 6, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfalquier sfalquier sfalquier requested changes

@mbarbet mbarbet mbarbet approved these changes

@MohamedHamouGisaia MohamedHamouGisaia MohamedHamouGisaia approved these changes

@sylvaingaudan sylvaingaudan Awaiting requested review from sylvaingaudan

Assignees

@alainbodiguel alainbodiguel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to java 17 Tests fail
4 participants
@alainbodiguel @sfalquier @mbarbet @MohamedHamouGisaia