Tests fail

[elouanKeryell-Even]

./release.sh breaks on tests execution (i.e. when not using --no-tests), with following error message:

===> start arlas-server stack
Creating network "arlas_default" with the default driver
Pulling elasticsearch (docker.elastic.co/elasticsearch/elasticsearch:6)...
manifest for docker.elastic.co/elasticsearch/elasticsearch:6 not found

Detailed description

• release.sh iterates over ELASTIC_RANGE to provide --es=<...> values for calls to ./scripts/tests-integration.sh. See here.
• ELASTIC_RANGE is in fact not an array, but a string, whose value is forced to 6, see here.
• This results in tests being called as follow:

./scripts/tests-integration.sh --es=6

• scripts/tests-integration.sh assigns value 6 to variable ELASTIC_VERSION (see here), which is then exported (see here)
• scripts/tests-integration.sh calls scripts/tests-integration-stage.sh, which in turn calls scripts/docker-run.sh, see here, here, here & here.
• scripts/docker-run.sh calls docker-compose (see here)
• the docker compose file uses variable ELASTIC_VERSION (== 6) as the tag for elasticsearch docker image, see here
• image docker.elastic.co/elasticsearch/elasticsearch:6 does not exist, the tests crash.

How to reproduce

time ./release.sh --simulate --api-major-version=0 --elastic-range=6  --arlas-release=0 --arlas-dev=0  --api-minor-version=0 --api-patch-version=0 | tee release_test_logs.txt

Fix

In this line, replace ELASTIC_RANGE with ELASTIC_VERSIONS.

[elouanKeryell-Even]

ping @MohamedHamouGisaia

[elouanKeryell-Even]

I think I might have fixed it in branch fix/release_tests (commit
c7b8a19), but I cannot perform a full execution of release.sh to validate, because of issue #412.