Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some fixes of tests on Windows #10

Merged
merged 2 commits into from
Feb 28, 2018
Merged

some fixes of tests on Windows #10

merged 2 commits into from
Feb 28, 2018

Conversation

mattn
Copy link
Contributor

@mattn mattn commented Feb 28, 2018

What does this do / why do we need it?

Fixes some OS specific tests.

How this PR fixes the problem?

Be possible to test on Windows

What should your reviewer look out for in this PR?

Use of filepath.ToSlash()

Check lists

  • Test passed
  • Coding style (indentation, etc)

Tests seems to be already broken.

@coveralls
Copy link

coveralls commented Feb 28, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 29

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.393%
Totals Coverage Status
Change from base Build 28: 0.0%
Covered Lines: 1180
Relevant Lines: 1630
💛 - Coveralls

wadackel
wadackel approved these changes Feb 28, 2018
View reviewed changes
Copy link
Member

@wadackel wadackel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mattn, Thank you for PR. LGTM 🎉
I learned a lot.

@wadackel wadackel added type: bug Something isn't working type: refactoring Refactoring source code or architecture labels Feb 28, 2018
@wadackel wadackel merged commit 6e1bbee into git-chglog:master Feb 28, 2018
@mattn mattn deleted the fix-test branch February 28, 2018 09:20
@wadackel wadackel mentioned this pull request Mar 1, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wadackel wadackel wadackel approved these changes

Assignees
No one assigned
Labels
type: bug Something isn't working type: refactoring Refactoring source code or architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattn @coveralls @wadackel