-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added in support for Sprig Go Template Functions #75
Conversation
Pull Request Test Coverage Report for Build 164
💛 - Coveralls |
@delmendo can you rebase please? |
) Also preserves coveralls and appveyor. Closes git-chglog#58
This reverts commit cbf3fda.
… releases"" This reverts commit 6e1fc86.
@delmendo this would be super helpful for users...can you clean this up so it can get merged in? |
I'll carve out some time today to work on this. |
Full disclosure - I know very little go - I only learned enough to modify this package to do most of what I wanted. I rebased and resubmitted. When I run the tests locally they pass - but there is something wrong with how the deps are being pulled over and I'm not sure where to start. If you could give me a pointer in what I'm doing wrong I'd be willing to put some more time in to try to get this to land |
I do have a suggestion. The commit that really matters here is only this one: 5f9300f Try this:
This will give you a cleaner base to work with, and should cleanup any dependency issues 🤞 |
…shed commits Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Signed-off-by: Dirk Elmendorf <dirk@r26d.com>
Signed-off-by: Dirk Elmendorf <dirk@r26d.com>
Ok so it looks like I did a number of other modifications to my version of Chglog ( I needed better handling for squash commits and some other changes - so after the rebase I didn't think you wanted all that version included. I created a new fork and generated the merge form there so it can be handled cleaner. It looks like Sprig has had a major version update since I did this work so I updated the library to use that so it will be easier to main tain in the future. Here is the new pull request - #99 let me know if there is anything else I need to do - or if you want the other changes I made to be submitted to the upstream. Glad to see this project is getting love again! |
Nice 👍 You should close this to cut down on the noise for the maintainers... |
What does this do / why do we need it?
This adds the template methods from Sprig to the git-chglog universe. The sprig library is a common toolkit for templates. I have used it a lot on the helm project for kubernetes.
I wanted to be able to deduplicate commit messages as well as do other formatting tasks that ship standard with sprig.
How this PR fixes the problem?
It just adds on the library and funcationality.
What should your reviewer look out for in this PR?
This is my first time contributing to a go project of any kind. I was able to get everything to compile and all tests pass on my machine. I'm still unfamiliar with the way things work in goland so please give me any feedback to
Check lists
Additional Comments (if any)
{Please write here}
Which issue(s) does this PR fix?
fixes #73
fixes #29