-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add install-from-source.sh
and surrounding infrastructure
#630
Add install-from-source.sh
and surrounding infrastructure
#630
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I have a couple of suggestions which I hope you will find helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far! I had a few ideas for avoiding --sudo-cmd
and some questions about modifying the PATH
and Git config.
6df41de
to
78394de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really happy with the organization here, but I'm getting a failure on my Ubuntu machine that seems surprising, since it works on the Actions Ubuntu runner.
2ef8eaf
to
dd63de8
Compare
dd63de8
to
981df86
Compare
Link to the latest validation run with all distros passing! https://github.com/ldennington/git-credential-manager/actions/runs/1953486987 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just one concern about a potential Bash-ism, otherwise looks good to me!
9dfa2d8
to
863821d
Compare
Update build.sh to support install from source scenario.
863821d
to
f70dd23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions about detecting dependencies and avoiding installing them.
f70dd23
to
8b0052f
Compare
Add script to help users automatically install from source on supported distributions.
Add new GitHub actions workflow to validate install from source on supported distributions.
Update README.md with instructions for downloading and running the install from source script.
8b0052f
to
b2a0717
Compare
Add a helper script for Linux users to install GCM from source. This includes:
build.sh
to support a new--install-from-source
parameter.README.md
. Note: These instructions will not work currently, as they point to the future location of the script inmain
.