Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install-from-source.sh and surrounding infrastructure #630

Merged
merged 4 commits into from
Mar 11, 2022

Conversation

ldennington
Copy link
Contributor

Add a helper script for Linux users to install GCM from source. This includes:

  1. Updates to build.sh to support a new --install-from-source parameter.
  2. Addition of the script itself.
  3. Addition of a new GitHub actions workflow to validate the script on supported distributions.
  4. Addition of instructions to obtain/run the script in README.md. Note: These instructions will not work currently, as they point to the future location of the script in main.

@ldennington ldennington self-assigned this Mar 2, 2022
Copy link
Collaborator

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have a couple of suggestions which I hope you will find helpful.

src/linux/Packaging.Linux/Packaging.Linux.csproj Outdated Show resolved Hide resolved
src/linux/Packaging.Linux/build.sh Outdated Show resolved Hide resolved
src/linux/Packaging.Linux/install-from-source.sh Outdated Show resolved Hide resolved
src/linux/Packaging.Linux/install-from-source.sh Outdated Show resolved Hide resolved
src/linux/Packaging.Linux/install-from-source.sh Outdated Show resolved Hide resolved
src/linux/Packaging.Linux/install-from-source.sh Outdated Show resolved Hide resolved
src/linux/Packaging.Linux/install-from-source.sh Outdated Show resolved Hide resolved
src/linux/Packaging.Linux/install-from-source.sh Outdated Show resolved Hide resolved
src/linux/Packaging.Linux/install-from-source.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@mjcheetham mjcheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far! I had a few ideas for avoiding --sudo-cmd and some questions about modifying the PATH and Git config.

src/linux/Packaging.Linux/install-from-source.sh Outdated Show resolved Hide resolved
src/linux/Packaging.Linux/install-from-source.sh Outdated Show resolved Hide resolved
src/linux/Packaging.Linux/install-from-source.sh Outdated Show resolved Hide resolved
src/linux/Packaging.Linux/install-from-source.sh Outdated Show resolved Hide resolved
.github/workflows/validate-install-from-source.yml Outdated Show resolved Hide resolved
src/linux/Packaging.Linux/install-from-source.sh Outdated Show resolved Hide resolved
src/linux/Packaging.Linux/install-from-source.sh Outdated Show resolved Hide resolved
src/linux/Packaging.Linux/install-from-source.sh Outdated Show resolved Hide resolved
src/linux/Packaging.Linux/install-from-source.sh Outdated Show resolved Hide resolved
@ldennington ldennington force-pushed the install-from-source branch 3 times, most recently from 6df41de to 78394de Compare March 7, 2022 19:28
Copy link
Contributor

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really happy with the organization here, but I'm getting a failure on my Ubuntu machine that seems surprising, since it works on the Actions Ubuntu runner.

.github/workflows/validate-install-from-source.yml Outdated Show resolved Hide resolved
.github/workflows/validate-install-from-source.yml Outdated Show resolved Hide resolved
src/linux/Packaging.Linux/install-from-source.sh Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ldennington ldennington force-pushed the install-from-source branch 13 times, most recently from 2ef8eaf to dd63de8 Compare March 8, 2022 19:55
@ldennington
Copy link
Contributor Author

Link to the latest validation run with all distros passing!

https://github.com/ldennington/git-credential-manager/actions/runs/1953486987

Copy link
Collaborator

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just one concern about a potential Bash-ism, otherwise looks good to me!

src/linux/Packaging.Linux/build.sh Outdated Show resolved Hide resolved
@ldennington ldennington force-pushed the install-from-source branch 2 times, most recently from 9dfa2d8 to 863821d Compare March 9, 2022 23:50
Update build.sh to support install from source scenario.
Copy link
Collaborator

@mjcheetham mjcheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions about detecting dependencies and avoiding installing them.

src/linux/Packaging.Linux/install-from-source.sh Outdated Show resolved Hide resolved
Add script to help users automatically install from source on supported
distributions.
Add new GitHub actions workflow to validate install from source on
supported distributions.
Update README.md with instructions for downloading and running the
install from source script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants