Fix install from source Debian compile bug #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, can't wait to see a new (non-pre) release! |
This was referenced Apr 5, 2022
Merged
Merged
| if [ $INSTALL_FROM_SOURCE = false ]; then | ||
| dpkg-deb --build "$DEBROOT" "$DEBPKG" || exit 1 | ||
| fi | ||
|
|
||
| # Create symlink | ||
| if [ ! -f "$LINK_TO/git-credential-manager-core" ]; then | ||
| ln -s -r "$INSTALL_TO/git-credential-manager-core" \ | ||
| "$LINK_TO/git-credential-manager-core" || exit 1 | ||
| fi | ||
|
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #644
A Linux user reported an oddly small Debian package associated with the 2.0.692 release. This was caused by the refactoring of
build.shin #630. The fix is fairly straightforward - we have to ensure our binaries are copied to the expected location before attempting to create the package. This change implements that fix, and also fixes a component of the symlink path that was also mistakenly dropped in #630.Here is the set of artifacts from before the fix was implemented, with the Debian package at an unlikely size of 940 B:
https://dev.azure.com/mseng/AzureDevOps/_build/results?buildId=17061102&view=artifacts&pathAsName=false&type=publishedArtifacts
Here is the set of artifacts from a test build I ran after the fix was implemented, with a more expected package size of 107 MB:
https://dev.azure.com/mseng/AzureDevOps/_build/results?buildId=17076015&view=artifacts&pathAsName=false&type=publishedArtifacts