git-wrapper: use git-<command> to call builtin #23
Conversation
|
@dscho For this to work we need the changes from git-for-windows/git#1561. |
Using a command line of the form: git-<command> <arguments>, will cause git to to treat the command as a builtin, preventing git from calling an external helper. Otherwise, git could call back to the wrapper leading to an infinite mutual recursion. Fixes git-for-windows/git#1496 Signed-off-by: Kim Gybels <kgybels@infogroep.be>
kgybels
force-pushed
the
use-builtin-syntax
branch
from
241f287
to
034f46f
Compare
|
Hmm. The way I read https://github.com/kgybels/MINGW-packages/blob/034f46f9599cf7242871562e75eb5113dc6bfcdc/mingw-w64-git/git-wrapper.c#L147, it would result in a command line |
|
A quick test shows that the latest snapshot still displays the bug, so I am eager to get this fixed. But I need to understand why your fix works before merging ;-) |
|
To handle builtin is_git_command is set to false. This also means the command line will no longer have a full path, but this is not a problem because when calling CreateProcess the full path is passed in as the first argument in addition to the command line. (https://github.com/kgybels/MINGW-packages/blob/034f46f9599cf7242871562e75eb5113dc6bfcdc/mingw-w64-git/git-wrapper.c#L638) |
That's what I was missing! Thanks! |
Using a command line of the form: git-<command> <arguments>, will cause
git to to treat the command as a builtin, preventing git from calling an
external helper. Otherwise, git could call back to the wrapper leading
to an infinite mutual recursion.
Fixes git-for-windows/git#1496