Use the Command Prompt as own name #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscho
reviewed
Nov 28, 2018
|
@mloskot thank you for opening this PR! I hope that we can come to a consensus about the best phrasing soon and merge it. |
Clarifies the Command Prompt is an own name, and qualifying it with Windows, i.e. Windows Command Prompt, is redundant. Similarly, full name of PowerShell on Windows is Windows PowerShell. Mention the Windows PowerShell in the 2nd choice description for even more clarity. Signed-off-by: Mateusz Łoskot <mateusz@loskot.net>
|
Thank you!!! |
dscho
added a commit
that referenced
this pull request
Nov 28, 2018
The confusing descriptions of the PATH options in the installer [were clarified](#216). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
I'm glad we've worked it out :-) Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies the Command Prompt is an own name, and qualifying it with Windows, i.e. Windows Command Prompt, is redundant. Similarly, full name of PowerShell on Windows is Windows PowerShell.
Mention the Windows PowerShell in the 2nd choice description for even more clarity.
References
Follow-up to the ML thread Git for Windows v2.20.0-rc0, where I argued use of the "Windows Command Prompt" in
is confusing, since
If I'm still trying to be anal about the naming, trying to find a rationale of it, I'd have considered the "Windows Command Prompt" as shortcut of "Windows' Command Prompt", "In Windows, Command Prompt" or "Command Prompt on Windows" :-)
Possibly, "Windows Command-line" may be better name for all command-line flavours on Windows, than "Windows Command Prompt".
https://en.wikipedia.org/wiki/PowerShell although now portable, for GfW case, it is clearer to state the old name:
https://en.wikipedia.org/wiki/Cmd.exe uses name "Command Prompt"
MSDN and docs.microsoft.com use "The Developer Command Prompt", not "The Developer Windows Command Prompt", to refer to the Command Prompt configured for Visual Studio toolsets.