Prepare for the architecture split between MSYS2 runtime 3.3.* vs 3.4.* #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is incredibly helpful because it allows for setting breakpoints, watches, single-stepping and more. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Git Credential Manager is special in that we do not actually _build_ the program, we simply re-bundle whatever the project published at https://github.com/git-ecosystem/git-credential-manager. Therefore, we can get away with _not_ triggering a separate aarch64 run, but we can bundle i686, x86_64 and aarch64 packages in a single workflow run. Verify that this is actually what happens. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Regular MINGW-packages (i.e. packages where the programs _have_ to be built, unlike, say, Git Credential Manager) need to be deployed in separate workflow runs for the i686/x86_64 and for the aarch64 architectures, as packages cannot be cross-compiled for different architectures (except for i686 and x86_64). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
We are about to change for which architectures the two separate MSYS2 runtime packages are built: the v3.3.* legacy package will be built only for i686, the regular package only for x86_64. To ensure that those changes are done correctly, let's document the current behavior first. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
There was a lot of copy/edited code in that part, owing to the fact that it is not _completely_ trivial to generalize adding the intended Check Runs, triggering the intended workflow runs, updating the PR comment with said information, and then updating the Check Runs, too. Unfortunately, there is no really good way to present this refactoring, as it collapses the separate MSYS2/MINGW code paths into a single one. The end result looks a lot cleaner, though, with the only tricky bit being how the comment is constructed (since there is now a variable number of workflow runs that may need to be listed). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
…tures
The purpose of introducing a separate `msys2-runtime-3.3` package is to
allow supporting Git for Windows on i686 setups, even though it cannot
receive updates to the latest MSYS2 runtime versions any longer because
the MSYS2 project dropped i686 support a long time ago.
To that end, let's actually build `msys2-runtime-3.3` _only_ for i686,
and `msys2-runtime` _only_ for x86_64.
That split will allow us to change the `msys2-runtime-3.3` package
definition so that it supersedes ("replaces") `msys2-runtime` and
automagically updates the 32-bit Git for Windows SDKs out there.
This is a step toward phasing out i686 support of Git for Windows, see:
git-for-windows/git#4279 (comment) for
more details about that plan.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From here on out, we will build
msys2-runtime-3.3only for i686, andmsys2-runtimeonly for x86_64. This is a necessary prerequisite for upgradingmsys2-runtimeto the current version, v3.4.6, because that simply does not support i686 anymore (and to accommodate for that, we movegit-sdk-32to usingmsys2-runtime-3.3instead ofmsys2-runtime).