Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for the architecture split between MSYS2 runtime 3.3.* vs 3.4.* #33

Merged
merged 6 commits into from
May 12, 2023
Merged

Prepare for the architecture split between MSYS2 runtime 3.3.* vs 3.4.* #33

merged 6 commits into from
May 12, 2023

Commits on May 12, 2023

  1. Document how to debug individual test cases in VS Code 

    This is incredibly helpful because it allows for setting breakpoints,
watches, single-stepping and more.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed May 12, 2023
    Configuration menu
    Copy the full SHA
    3821b65 View commit details
    Browse the repository at this point in the history

  2. tests: verify that GCM deployments trigger only one combined run 

    Git Credential Manager is special in that we do not actually _build_ the
program, we simply re-bundle whatever the project published at
https://github.com/git-ecosystem/git-credential-manager.

Therefore, we can get away with _not_ triggering a separate aarch64
run, but we can bundle i686, x86_64 and aarch64 packages in a single
workflow run.

Verify that this is actually what happens.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed May 12, 2023
    Configuration menu
    Copy the full SHA
    35c2d28 View commit details
    Browse the repository at this point in the history

  3. tests: verify regular MINGW-packages deployments 

    Regular MINGW-packages (i.e. packages where the programs _have_ to be
built, unlike, say, Git Credential Manager) need to be deployed in
separate workflow runs for the i686/x86_64 and for the aarch64
architectures, as packages cannot be cross-compiled for different
architectures (except for i686 and x86_64).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed May 12, 2023
    Configuration menu
    Copy the full SHA
    30ae420 View commit details
    Browse the repository at this point in the history

  4. tests: verify MSYS2 runtime deployments 

    We are about to change for which architectures the two separate MSYS2
runtime packages are built: the v3.3.* legacy package will be built only
for i686, the regular package only for x86_64.

To ensure that those changes are done correctly, let's document the
current behavior first.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed May 12, 2023
    Configuration menu
    Copy the full SHA
    fd43ea1 View commit details
    Browse the repository at this point in the history

  5. DRY up the /deploy handling 

    There was a lot of copy/edited code in that part, owing to the fact that
it is not _completely_ trivial to generalize adding the intended Check
Runs, triggering the intended workflow runs, updating the PR comment
with said information, and then updating the Check Runs, too.

Unfortunately, there is no really good way to present this refactoring,
as it collapses the separate MSYS2/MINGW code paths into a single one.

The end result looks a lot cleaner, though, with the only tricky bit
being how the comment is constructed (since there is now a variable
number of workflow runs that may need to be listed).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed May 12, 2023
    Configuration menu
    Copy the full SHA
    11d7b2d View commit details
    Browse the repository at this point in the history

  6. /deploy: no longer build the MSYS2 runtime packages for both architec… 

    …tures

The purpose of introducing a separate `msys2-runtime-3.3` package is to
allow supporting Git for Windows on i686 setups, even though it cannot
receive updates to the latest MSYS2 runtime versions any longer because
the MSYS2 project dropped i686 support a long time ago.

To that end, let's actually build `msys2-runtime-3.3` _only_ for i686,
and `msys2-runtime` _only_ for x86_64.

That split will allow us to change the `msys2-runtime-3.3` package
definition so that it supersedes ("replaces") `msys2-runtime` and
automagically updates the 32-bit Git for Windows SDKs out there.

This is a step toward phasing out i686 support of Git for Windows, see:
git-for-windows/git#4279 (comment) for
more details about that plan.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    @dscho
    dscho committed May 12, 2023
    Configuration menu
    Copy the full SHA
    1da3d8a View commit details
    Browse the repository at this point in the history