Weekly Digest (10 November, 2019 - 17 November, 2019)

[weekly-digest]

Here's the Weekly Digest for git-for-windows/git:

---

ISSUES

Last week 8 issues were created.
Of these, 2 issues have been closed and 6 issues are still open.

OPEN ISSUES

💚 #2407 Pacman Retrieving packages error with QueryUnbiasedInterruptTime function call, by rdjondo
💚 #2406 bug:git stash pop -q in 2.24.0, by hiroyuki-okazaki-shi
💚 #2405 Make sure errno is set when socket operations fail, by dscho
💚 #2404 mingw_setsockopt() should set errno, by jeffhostetler
💚 #2403 When installing to a non-default directory, by anders43
💚 #2401 [TEST BALLOON] ci: use GitHub Actions, by dscho

CLOSED ISSUES

❤️ #2402 built-in add -i/-p: update to latest iteration, by dscho
❤️ #2400 [TEST] Use a more native way to download the git-sdk-64-minimal artifact, by dscho

LIKED ISSUE

👍 #2404 mingw_setsockopt() should set errno, by jeffhostetler
It received 👍 x1, 😄 x0, 🎉 x0 and ❤️ x0.

NOISY ISSUE

🔈 #2403 When installing to a non-default directory, by anders43
It received 8 comments.

---

PULL REQUESTS

Last week, 5 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 4 pull requests were updated.
💛 #2405 Make sure errno is set when socket operations fail, by dscho
💛 #2401 [TEST BALLOON] ci: use GitHub Actions, by dscho
💛 #2399 WIP config: allow user to know type of config options, by ROGERSM94
💛 #686 Block paths which might be misinterpreted as alternate file streams, by latkin

MERGED PULL REQUEST

Last week, 1 pull request was merged.
💜 #2402 built-in add -i/-p: update to latest iteration, by dscho

---

COMMITS

Last week there were 10 commits.
🛠️ Merge pull request #2402 from dscho/add-i-in-c-status-and-help-gfw built-in add -i/-p: update to latest iteration by dscho
🛠️ fixup! built-in add -i: prepare for multi-selection commands During a final review before submitting it, this developer stumbled over the fact that the result of strtoul() was decremented by one for from, but not for to. Let's add a code comment to stave off confusion. Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de by dscho
🛠️ fixup! built-in add -i: implement the main loop Whoops, a buffer overrun. Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de by dscho
🛠️ fixup! built-in add -i: implement the update command Let's not rename the unused_opts parameter; It is still unused. Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de by dscho
🛠️ fixup! built-in add -p: implement hunk editing Phillip Wood pointed out, long ago, that the code is underdocumented and could use a helper for calling the editor. Somehow, this change only made it into https://github.com/gitgitgadget/git/pull/173 but not into Git for Windows' master. Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de by dscho
🛠️ strbuf: add a helper function to call the editor "on an strbuf" This helper supports the scenario where Git has a populated strbuf and wants to let the user edit it interactively. In git add -p, we will use this to allow interactive hunk editing: the diff hunks are already in memory, but we need to write them out to a file so that an editor can be launched, then read everything back once the user is done editing. Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de by dscho
🛠️ fixup! built-in add -p: coalesce hunks after splitting them Phillip Wood pointed out, long ago, that temp -> merged would make it easier to read this code. Somehow, this change only made it into https://github.com/gitgitgadget/git/pull/173 but not into Git for Windows' master. Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de by dscho
🛠️ fixup! built-in add -p: implement the hunk splitting feature A long time ago, Phillip Wood pointed out that this would be easier to read, and I agreed, but failed to backport the fix to Git for Windows' master branch. Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de by dscho
🛠️ squash! built-in add -i: implement the main loop built-in add -i: implement the main loop The reason why we did not start with the main loop to begin with is that it is the first user of list_and_choose(), which uses the list() function that we conveniently introduced for use by the status command. In contrast to the Perl version, in the built-in interactive add, we will keep the list() function (which only displays items) and the list_and_choose() function (which uses list() to display the items, and only takes care of the "and choose" part) separate. The list_and_choose() function, as implemented in git-add--interactive.perl knows a few more tricks than the function we introduce in this patch: - There is a flag to let the user select multiple items. - In multi-select mode, the list of items is prefixed with a marker indicating what items have been selected. - Initially, for each item a unique prefix is determined (if there exists any within the given parameters), and shown in the list, and accepted as a shortcut for the selection. These features will be implemented in the C version later. This patch does not add any new main loop command, of course, the built-in git add -i still only supports the status command. The remaining commands to follow over the course of the next commits. To accommodate for listing the commands in columns, preparing for the commands that will be implemented over the course of the next patches/patch series, we teach the list() function to do precisely that. Note that we only have a prompt ending in a single ">" at this stage; later commits will add commands that display a double ">>" to indicate that the user is in a different loop than the main one. Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de by dscho
🛠️ squash! Start to implement a built-in version of git add --interactive [TODO! Cherry-pick the latest changes from gitgitgadget/git#170] Start to implement a built-in version of git add --interactive Unlike previous conversions to C, where we started with a built-in helper, we start this conversion by adding an interception in the run_add_interactive() function when the new opt-in add.interactive.useBuiltin config knob is turned on (or the corresponding environment variable GIT_TEST_ADD_I_USE_BUILTIN), and calling the new internal API function run_add_i() that is implemented directly in libgit.a. At this point, the built-in version of git add -i only states that it cannot do anything yet. In subsequent patches/patch series, the run_add_i() function will gain more and more functionality, until it is feature complete. The whole arc of the conversion can be found in the PRs #170-175 at https://github.com/gitgitgadget/git. The "--helper approach" can unfortunately not be used here: on Windows we face the very specific problem that a system() call in Perl seems to close stdin in the parent process when the spawned process consumes even one character from stdin. Which prevents us from implementing the main loop in C and still trying to hand off to the Perl script. The very real downside of the approach we have to take here is that the test suite won't pass with GIT_TEST_ADD_I_USE_BUILTIN=true until the conversion is complete (the --helper approach would have let it pass, even at each of the incremental conversion steps). Signed-off-by: Johannes Schindelin johannes.schindelin@gmx.de by dscho

---

CONTRIBUTORS

Last week there was 1 contributor.
👤 dscho

---

STARGAZERS

Last week there were 19 stagazers.
⭐ ckedd
⭐ chrisluedtke
⭐ ko-han
⭐ zhu-chao
⭐ jogo-
⭐ yaoqs
⭐ liuyongchen
⭐ eivindgl
⭐ Inshal240
⭐ wangxiao1208
⭐ nmuzychuk
⭐ Nikokn
⭐ andongJ
⭐ GeekyMoose
⭐ maotianni
⭐ kmchmk1026
⭐ sgf
⭐ CharlotteFallices
⭐ xcodejoy
You all are the stars! 🌟

---

RELEASES

Last week there were no releases.

---

That's all for last week, please 👀 Watch and ⭐ Star the repository git-for-windows/git to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆