mingw: use CreateHardLink directly #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The upstream has some older version of this which would conflict, I'll submit the cleanup there as well |
dscho
reviewed
Oct 27, 2017
compat/mingw.c
Outdated
| @@ -2,6 +2,7 @@ | |||
| #include "win32.h" | |||
| #include <conio.h> | |||
| #include <wchar.h> | |||
| #include <windows.h> | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Thank you! As I pointed out, this should compile correctly without the extra Thanks! |
|
Oh, and if you could sign off on the patch? I need that to be able to submit this same patch upstream after cooking it in Git for Windows for a while. |
max630
force-pushed
the
mingw-direct-CreateHardLinkW
branch
from
9ac5f33
to
99f0c95
Compare
It was observed that the current implementation of of get_proc_addr() fails to load the kernel32.dll with code ERROR_INVALID_PARAMETER. Probably the reason is that kernel32.dll is already loaded. The behavior was seen at Windows SP1, both 32bit and 64bit. Probably it would behave same way in some or all other Windows versions. This breaks all usages of "clone --local", including the automatic tests where they call it. The function CreateHardLink is available in all supported Windows versions (since Windows XP), so there is no more need to resolve it in runtime. Signed-off-by: Max Kirillov <max@max630.net>
max630
force-pushed
the
mingw-direct-CreateHardLinkW
branch
from
99f0c95
to
e9630ae
Compare
|
I have updated the commit. It build and passes at least some tests. Runnig full suite now but I expect it to be ok |
|
Perfect, thanks! |
dscho
added a commit
that referenced
this pull request
Oct 30, 2017
mingw: use CreateHardLink directly
dscho
added a commit
that referenced
this pull request
Nov 1, 2017
mingw: use CreateHardLink directly
dscho
added a commit
that referenced
this pull request
Nov 6, 2017
mingw: use CreateHardLink directly
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 7, 2017
mingw: use CreateHardLink directly
dscho
added a commit
that referenced
this pull request
Nov 29, 2017
mingw: use CreateHardLink directly
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 6, 2017
mingw: use CreateHardLink directly
dscho
added a commit
that referenced
this pull request
Jan 2, 2018
mingw: use CreateHardLink directly
dscho
added a commit
that referenced
this pull request
Jan 18, 2018
mingw: use CreateHardLink directly
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 20, 2018
mingw: use CreateHardLink directly
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 22, 2018
mingw: use CreateHardLink directly
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 22, 2018
mingw: use CreateHardLink directly
dscho
added a commit
that referenced
this pull request
Jan 22, 2018
mingw: use CreateHardLink directly
dscho
added a commit
that referenced
this pull request
Feb 16, 2018
mingw: use CreateHardLink directly
dscho
added a commit
that referenced
this pull request
Mar 23, 2018
mingw: use CreateHardLink directly
dscho
added a commit
that referenced
this pull request
Apr 3, 2018
mingw: use CreateHardLink directly
dscho
added a commit
that referenced
this pull request
May 29, 2018
mingw: use CreateHardLink directly
dscho
added a commit
that referenced
this pull request
May 29, 2018
mingw: use CreateHardLink directly
PKRoma
pushed a commit
to PKRoma/git-for-windows
that referenced
this pull request
Jun 22, 2018
…teHardLinkW mingw: use CreateHardLink directly
PKRoma
pushed a commit
to PKRoma/git-for-windows
that referenced
this pull request
Jun 22, 2018
…teHardLinkW mingw: use CreateHardLink directly
PKRoma
pushed a commit
to PKRoma/git-for-windows
that referenced
this pull request
Jun 22, 2018
…teHardLinkW mingw: use CreateHardLink directly
dscho
added a commit
that referenced
this pull request
Aug 22, 2018
mingw: use CreateHardLink directly
dscho
added a commit
to dscho/git
that referenced
this pull request
Aug 22, 2018
…teHardLinkW mingw: use CreateHardLink directly
dscho
added a commit
that referenced
this pull request
Aug 23, 2018
mingw: use CreateHardLink directly
dscho
added a commit
that referenced
this pull request
Aug 23, 2018
mingw: use CreateHardLink directly
dscho
added a commit
that referenced
this pull request
Aug 23, 2018
mingw: use CreateHardLink directly
jamill
pushed a commit
to jamill/git
that referenced
this pull request
Aug 28, 2018
…teHardLinkW mingw: use CreateHardLink directly
jamill
pushed a commit
to jamill/git
that referenced
this pull request
Sep 5, 2018
…teHardLinkW mingw: use CreateHardLink directly
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 10, 2018
mingw: use CreateHardLink directly
jamill
pushed a commit
to jamill/git
that referenced
this pull request
Sep 11, 2018
…teHardLinkW mingw: use CreateHardLink directly
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 24, 2018
mingw: use CreateHardLink directly
dscho
added a commit
that referenced
this pull request
Oct 10, 2018
mingw: use CreateHardLink directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was observed that the current implementation of of get_proc_addr()
fails to load the kernel32.dll with code ERROR_INVALID_PARAMETER.
Probably the reason is that kernel32.dll is already loaded. The
behavior was seen at Windows SP1, both 32bit and 64bit. Probably it
would behave same way in some or all other Windows versions.
This breaks all usages of "clone --local", including the automatic
tests where they call it.
The function CreateHardLink is available in all supported Windows
versions (since Windows XP), so there is no more need to resolve it
in runtime.