Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doc formatting error in git.txt #1597

Merged
merged 1 commit into from
Mar 30, 2018
Merged

Fix doc formatting error in git.txt #1597

merged 1 commit into from
Mar 30, 2018

Conversation

alejandro5042
Copy link

Fixing the header for Environment Variables > System header added in b2956b3.

Original PR: #1548

@alejandro5042 alejandro5042 mentioned this pull request Mar 28, 2018
Merged
nalla
nalla approved these changes Mar 28, 2018
View reviewed changes
Copy link

@nalla nalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nalla
Copy link

nalla commented Mar 28, 2018 •
edited
Loading

If you want you can git commit --amend the commit and change the subject line to respect the topic: Description scheme.

E.g.

git.txt: Fix doc formatting error

Fixing the header for Environment Variables > System header added in
b2956b3.

@alejandro5042
git.txt: Fix doc formatting error
399e3e5 
Fixing the header for Environment Variables > System header added in
b2956b3.

Signed-off-by: Alejandro Barreto <alejandro5042@gmail.com>
@alejandro5042
Copy link
Author

OK, I amended the commit to contain the new message. Thanks!

@dscho
Copy link
Member

dscho commented Mar 30, 2018

Thank you!

@dscho dscho merged commit 9761067 into git-for-windows:master Mar 30, 2018
@alejandro5042 alejandro5042 deleted the patch-3 branch April 3, 2018 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalla nalla nalla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alejandro5042 @nalla @dscho