Fix t2040 #2415
Merged
Fix t2040 #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To verify that the symlink is resolved correctly, we use the fact that `git.exe` is a native Win32 program, and that `git.exe config -f <path>` therefore uses the native symlink resolution. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the current agents of the Azure Pipeline pool
vs2017-win2016are not actually Windows 2016, as thecmd.exe /c 'type [...]'call contains the tell-tale... and the test fails that tries to verify that symbolic links are created with the correct type (on Windows, symbolic links have a defined target type: directory or file).
Let's fix that by not using
cmd.exe /c 'type [...]'to read the files (and thereby resolving the symbolic links), but by usinggit config -f [...]instead (which also resolves the symbolic links).A more complete fix would be to add a test helper that verifies the actual type of the symbolic link; The advantage of the current approach is that it tests the code flow that we actually need to keep working.