git add -i: handle CR/LF line endings in the interactive input #2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Git for Windows v2.27.0, there is an option to use Windows' newly-introduced Pseudo Console support. When running an interactive add operation with this support enabled, Git will receive CR/LF line endings. Therefore, let's not pretend that we are expecting Unix line endings. This fixes git-for-windows#2729 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
1 task
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 2, 2020
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 2, 2020
git add -i: handle CR/LF line endings in the interactive input
dscho
added a commit
that referenced
this pull request
Jul 2, 2020
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 3, 2020
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 3, 2020
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 3, 2020
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 7, 2020
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 7, 2020
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 7, 2020
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 7, 2020
git add -i: handle CR/LF line endings in the interactive input
dscho
added a commit
that referenced
this pull request
Jul 8, 2020
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jul 9, 2020
git add -i: handle CR/LF line endings in the interactive input
dscho
added a commit
that referenced
this pull request
Jul 9, 2020
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 22, 2024
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 22, 2024
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 23, 2024
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 23, 2024
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 24, 2024
git add -i: handle CR/LF line endings in the interactive input
dscho
added a commit
to microsoft/git
that referenced
this pull request
Apr 24, 2024
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 24, 2024
git add -i: handle CR/LF line endings in the interactive input
dscho
added a commit
that referenced
this pull request
Apr 25, 2024
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 25, 2024
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 25, 2024
git add -i: handle CR/LF line endings in the interactive input
dscho
added a commit
that referenced
this pull request
Apr 25, 2024
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 25, 2024
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 26, 2024
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 26, 2024
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 26, 2024
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 26, 2024
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 26, 2024
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 27, 2024
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 27, 2024
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 29, 2024
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 29, 2024
git add -i: handle CR/LF line endings in the interactive input
dscho
added a commit
to microsoft/git
that referenced
this pull request
Apr 29, 2024
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 29, 2024
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
Apr 29, 2024
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 1, 2024
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 1, 2024
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 1, 2024
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 4, 2024
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 4, 2024
git add -i: handle CR/LF line endings in the interactive input
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 9, 2024
git add -i: handle CR/LF line endings in the interactive input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Git for Windows v2.27.0, there is an option to use Windows' newly-introduced Pseudo Console support. When running an interactive add operation with this support enabled, Git will receive CR/LF line
endings.
Therefore, let's not pretend that we are expecting Unix line endings.
This fixes #2729