Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better cross-platform Makefile #1633

Merged
merged 2 commits into from
Aug 7, 2020
Merged

Better cross-platform Makefile #1633

merged 2 commits into from
Aug 7, 2020

Conversation

kevgo
Copy link
Contributor

@kevgo kevgo commented Aug 7, 2020

Windows 10 can handle mixing forward and backslashes in paths, so this is a much more elegant and less awkward solution for cross-platform paths in Makefiles in my opinion.

Copy link
Collaborator

@charlierudolph charlierudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Glad we don't need that logic in the Makefile anymore

@kevgo kevgo merged commit 1c5b128 into master Aug 7, 2020
@kevgo kevgo deleted the kg-make-cross-platform branch August 7, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants