Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various typo fixes, clarifications and additions to the current Rev News #228

Merged
merged 17 commits into from Feb 21, 2017

Conversation

dscho
Copy link
Member

@dscho dscho commented Feb 20, 2017

No description provided.

I did not. All I did was to kick off a discussion how we could improve
the current situation.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Copy link
Contributor

@tfnico tfnico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'll leave it open for @chriscool to have a look as well.

@@ -435,7 +435,7 @@ __Events__

___Git Merge 2017___

Apparently, an increasing number of excellent bloggers attented the conference:
Apparently, an increasing number of excellent bloggers attend the conference:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be "attended".

contributors are Cc:ed in that email. At present, the
“what’s cooking” email is mostly generated in an automated
way from the [`todo`
branch](https://github.com/git/git/commits/todo) using
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am always afraid by links that span several lines as I had problems with them before.

@@ -224,6 +224,7 @@ the [Git Merge 2017](http://git-merge.com/) conference that happenend on Februar
appeared in the Linux Kernel world (especially on the Intel side).
Johannes emphazised his willingness to establish tools which help to improve the situation.
It was mentioned that code/commit notes should point to mailing list where appropriate.
Josh Triplett steered the discussion toward distributed review tools, and mentioned that there is already a data format for that purpose: ReviewDB. This format, however, would need to be extended to allow for addressing the issues raised in the discussion.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: it would be nice if this was split into several lines and indented.

@chriscool
Copy link
Collaborator

Ok I have a few minor comments, but as overall it looks very good, let's merge this for now.

@chriscool chriscool merged commit 85b717c into git:master Feb 21, 2017
@chriscool
Copy link
Collaborator

Thanks a lot!

@dscho
Copy link
Member Author

dscho commented Feb 21, 2017

I think it should be "attended".

If you wrote "Apparently, an increasing number of excellent bloggers attend the conference" then it really means that during this conference, more and more bloggers arrived. That is not what we meant here, right? If you write "an increasing number of bloggers attend the conference", then you are referring to the conference as a recurring event.

@dscho dscho deleted the rev-news branch February 21, 2017 14:09
@chriscool
Copy link
Collaborator

Yeah, I understand. The sentence we are discussing was written by @mjaix, and I am just guessing that he wanted to write "attended", but maybe it's better with "attend" anyway.

@mjaix
Copy link
Contributor

mjaix commented Feb 21, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants