-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various typo fixes, clarifications and additions to the current Rev News #228
Conversation
I did not. All I did was to kick off a discussion how we could improve the current situation. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I'll leave it open for @chriscool to have a look as well.
@@ -435,7 +435,7 @@ __Events__ | |||
|
|||
___Git Merge 2017___ | |||
|
|||
Apparently, an increasing number of excellent bloggers attented the conference: | |||
Apparently, an increasing number of excellent bloggers attend the conference: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be "attended".
contributors are Cc:ed in that email. At present, the | ||
“what’s cooking” email is mostly generated in an automated | ||
way from the [`todo` | ||
branch](https://github.com/git/git/commits/todo) using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am always afraid by links that span several lines as I had problems with them before.
rev_news/drafts/edition-24.md
Outdated
@@ -224,6 +224,7 @@ the [Git Merge 2017](http://git-merge.com/) conference that happenend on Februar | |||
appeared in the Linux Kernel world (especially on the Intel side). | |||
Johannes emphazised his willingness to establish tools which help to improve the situation. | |||
It was mentioned that code/commit notes should point to mailing list where appropriate. | |||
Josh Triplett steered the discussion toward distributed review tools, and mentioned that there is already a data format for that purpose: ReviewDB. This format, however, would need to be extended to allow for addressing the issues raised in the discussion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: it would be nice if this was split into several lines and indented.
Ok I have a few minor comments, but as overall it looks very good, let's merge this for now. |
Thanks a lot! |
If you wrote "Apparently, an increasing number of excellent bloggers attend the conference" then it really means that during this conference, more and more bloggers arrived. That is not what we meant here, right? If you write "an increasing number of bloggers attend the conference", then you are referring to the conference as a recurring event. |
Yeah, I understand. The sentence we are discussing was written by @mjaix, and I am just guessing that he wanted to write "attended", but maybe it's better with "attend" anyway. |
IMHO "attend" sounds better, and was the intention :-) ... thanks!
|
No description provided.