Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix italian expression #1442

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix italian expression #1442

wants to merge 1 commit into from

Conversation

paolobenve
Copy link

In italian "aggiornato rispetto a" means "ahead of".

"Up to date with something" is to be translated
"aggiornato a qualcosa".

Signed-off-by: Paolo Benvenuto paolobenve@gmail.com

@paolobenve
fix italian expression
9f32c09 
In italian "aggiornato rispetto a" means "ahead of".

"Up to date with something" is to be translated
"aggiornato a qualcosa".

Signed-off-by: Paolo Benvenuto <paolobenve@gmail.com>
@paolobenve
Copy link
Author

/preview

@gitgitgadget-git
Copy link

Preview email sent as pull.1442.git.git.1674670546535.gitgitgadget@gmail.com

@paolobenve
Copy link
Author

/submit

@gitgitgadget-git
Copy link

Submitted as pull.1442.git.git.1674670628292.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-git-1442/paolobenve/paolobenve-italian-fix-v1

To fetch this version to local tag pr-git-1442/paolobenve/paolobenve-italian-fix-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-git-1442/paolobenve/paolobenve-italian-fix-v1

@paolobenve
Copy link
Author

/allow

@gitgitgadget-git
Copy link

User paolobenve already allowed to use GitGitGadget.

RSilicon pushed a commit to RSilicon/git that referenced this pull request Jan 27, 2023
@dscho
checkout.c: enable fscache for checkout again
9d0e5db 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Mar 15, 2023
@dscho
checkout.c: enable fscache for checkout again
d4e6747 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Mar 15, 2023
@dscho
checkout.c: enable fscache for checkout again
64b273c 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Mar 15, 2023
@dscho
checkout.c: enable fscache for checkout again
359d6d9 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Mar 15, 2023
@dscho
checkout.c: enable fscache for checkout again
d8ebf7c 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Mar 15, 2023
@dscho
checkout.c: enable fscache for checkout again
bd5740f 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Mar 15, 2023
@dscho
checkout.c: enable fscache for checkout again
72a658f 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request May 11, 2023
@dscho
checkout.c: enable fscache for checkout again
a74abe9 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 23, 2023
@dscho
checkout.c: enable fscache for checkout again
47cb0fd 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 23, 2023
@dscho
checkout.c: enable fscache for checkout again
e3ba5e8 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 23, 2023
@dscho
checkout.c: enable fscache for checkout again
2f475c9 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Aug 23, 2023
@dscho
checkout.c: enable fscache for checkout again
465350d 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
vdye pushed a commit to vdye/git that referenced this pull request Jan 9, 2024
@vdye
checkout.c: enable fscache for checkout again
9398cd0 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
vdye pushed a commit to vdye/git that referenced this pull request Jan 9, 2024
@vdye
checkout.c: enable fscache for checkout again
6913482 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
vdye pushed a commit to vdye/git that referenced this pull request Jan 9, 2024
@vdye
checkout.c: enable fscache for checkout again
e1d3a84 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
vdye pushed a commit to vdye/git that referenced this pull request Jan 9, 2024
@mjcheetham
checkout.c: enable fscache for checkout again
d74314b 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
vdye pushed a commit to vdye/git that referenced this pull request Jan 9, 2024
@mjcheetham
checkout.c: enable fscache for checkout again
9742f2e 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Apr 30, 2024
@dscho
checkout.c: enable fscache for checkout again
b8a098a 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Apr 30, 2024
@dscho
checkout.c: enable fscache for checkout again
e8df0cc 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Apr 30, 2024
@dscho
checkout.c: enable fscache for checkout again
9e0d3fa 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jun 19, 2024
@dscho
checkout.c: enable fscache for checkout again
a7255cf 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Jul 19, 2024
@dscho
checkout.c: enable fscache for checkout again
d18a16b 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
ohhmm pushed a commit to ohhmm/git that referenced this pull request Aug 11, 2024
@mjcheetham
checkout.c: enable fscache for checkout again
d27c615 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
ohhmm pushed a commit to ohhmm/git that referenced this pull request Aug 11, 2024
@mjcheetham
checkout.c: enable fscache for checkout again
abf23e3 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
ohhmm pushed a commit to ohhmm/git that referenced this pull request Aug 11, 2024
@mjcheetham
checkout.c: enable fscache for checkout again
f202666 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
derrickstolee pushed a commit to derrickstolee/git that referenced this pull request Sep 18, 2024
@dscho
checkout.c: enable fscache for checkout again
0b3cb86 
This is retry of git#1419.

I added flush_fscache macro to flush cached stats after disk writing
with tests for regression reported in git#1438 and git#1442.

git checkout checks each file path in sorted order, so cache flushing does not
make performance worse unless we have large number of modified files in
a directory containing many files.

Using chromium repository, I tested `git checkout .` performance when I
delete 10 files in different directories.
With this patch:
TotalSeconds: 4.307272
TotalSeconds: 4.4863595
TotalSeconds: 4.2975562
Avg: 4.36372923333333

Without this patch:
TotalSeconds: 20.9705431
TotalSeconds: 22.4867685
TotalSeconds: 18.8968292
Avg: 20.7847136

I confirmed this patch passed all tests in t/ with core_fscache=1.

Signed-off-by: Takuto Ikuta <tikuta@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@paolobenve