Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-subtree: Avoid using echo -n even indirectly #61

Closed
wants to merge 1 commit into from

Conversation

Blaisorblade
Copy link

Since say uses echo, this uses echo -n, which is not portable - see
19c3c5f.

Without this commit, the output looks like:

...
-n 1891/    1936 (1883)
-n 1892/    1936 (1884)
-n 1893/    1936 (1885)
...

Signed-off-by: Paolo G. Giarrusso p.giarrusso@gmail.com


I am submitting this patch by email as requested; however, email is an inferior tracker interface compared to pull requests, at least for me. This pull request allows me to track this patch.

Since say uses echo, this uses echo -n, which is not portable - see
19c3c5f.

Without this commit, the output looks like:

...
-n 1891/    1936 (1883)
-n 1892/    1936 (1884)
-n 1893/    1936 (1885)
...

Signed-off-by: Paolo G. Giarrusso <p.giarrusso@gmail.com>
@Blaisorblade
Copy link
Author

I'll close this myself when I'll be aware the patch has been merged.

@n1xim
Copy link

n1xim commented Oct 28, 2013

@Blaisorblade If you wish to submit a patch please follow the instructions in Documentation/SubmittingPatches. All Git integration happens on the mailinglist.

@Blaisorblade
Copy link
Author

@n1xim I read the instructions, thus I wrote:

I am submitting this patch by email as requested; however, email is an inferior tracker interface compared to pull requests, at least for me. This pull request allows me to track this patch.

I could have added a link to the thread. Here it is:
http://git.661346.n2.nabble.com/PATCH-git-subtree-Avoid-using-echo-n-even-indirectly-tt7597331.html#none

BTW, since the patch still merges, it seems clear that no action was taken. Update: luckily, this entry tracks the fact that the patch is not merged.

Is there any other bug tracker? If so, I'd be happy to use it. If not (and it does not seem to be the case), I think you should have one.

@petervanderdoes
Copy link
Contributor

Please close the request.

@Blaisorblade
From the README

The user discussion and development of Git take place on the Git
mailing list -- everyone is welcome to post bug reports, feature
requests, comments and patches to git@vger.kernel.org (read
Documentation/SubmittingPatches for instructions on patch submission).

So that's your bug tracker.

@Blaisorblade
Copy link
Author

I contend a ML implements no feature of a bug tracker. Closing this anyway.

max630 pushed a commit to max630/git that referenced this pull request May 17, 2015
fixup! Silence GCC's "cast of pointer to integer of a different size" warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants